Skip to content

fix: #10 bug: Throws an error if scss-file is empty #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2016
Merged

fix: #10 bug: Throws an error if scss-file is empty #12

merged 1 commit into from
Oct 17, 2016

Conversation

m-abs
Copy link
Contributor

@m-abs m-abs commented Oct 7, 2016

  • Will no longer throw an error for empty files
  • nativescript-angular: ng2 throws errors if css-files doesn't exist, to accommodate that write empty css-files if the sass-file is empty

@m-abs
fix: #10 bug: Throws an error if scss-file is empty
5e4939d 
* Will no longer throw an error for empty files
* nativescript-angular: ng2 throws errors if css-files doesn't exist, to accommodate that write empty css-files if the sass-file is empty
@toddanglin
Copy link
Contributor

Thanks @m-abs! Change makes sense, though it would be a big change to "standard" behavior/output.

@NathanWalker Does this check-out for you, too? If so, I'll merge and update.

@toddanglin toddanglin merged commit 5e4939d into NativeScript:master Oct 17, 2016
@NathanWalker
Copy link
Contributor

Very helpful @m-abs - have run into this many times before!
Thank you! @toddanglin 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-abs @toddanglin @NathanWalker @jacobedawson